test(replay): Test against full and errors+replay CDN bundles #7096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms-replay-pw-add-bundles
branch
from
616bb48 to
dda86ba
Compare
size-limit report 📦
|
Lms24
force-pushed
the
lms-replay-pw-add-bundles
branch
from
dda86ba to
4f53323
Compare
Lms24
force-pushed
the
lms-replay-pw-add-bundles
branch
2 times, most recently
from
702c517 to
043a358
Compare
This was referenced Feb 10, 2023
Lms24
force-pushed
the
lms-replay-pw-add-bundles
branch
from
043a358 to
18eeb79
Compare
Lms24
force-pushed
the
lms-replay-pw-add-bundles
branch
from
18eeb79 to
9b5710e
Compare
Lms24
force-pushed
the
lms-replay-pw-add-bundles
branch
from
088eef7 to
7bec22f
Compare
Lms24
changed the title
billyvg
approved these changes
Feb 10, 2023
|
oof accidentally selected merge instead of squash+rebase, sorry about that 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our Playwright test setup to test against four new SDK CDN bundles:
To make this work and simplify our test case inits, I decided to drop testing against the replay addon CDN bundle which we recently decided to deprecate in favour of the full bundles. This has the nice side effect that our PW setup is slightly simplified.
Overall, this change adds four more PW test jobs to CI but I've checked runtime and the impact seems negligible.
ref #7044
Also, cc @billyvg - once this is merged, I think #7055 should work better. You might need to update your init.js file.